Only use boost workers for leveldb shadow queues #15696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The leveldb shadow queue of a persistable channel queue should always start with 0 workers and just use boost to add additional workers if necessary. Signed-off-by: Andrew Thornton <art27@cantab.net>
6543
approved these changes
May 1, 2021
GiteaBot
added
the
lgtm/need 1
… to start the workers Signed-off-by: Andrew Thornton <art27@cantab.net>
6 tasks
Signed-off-by: Andrew Thornton <art27@cantab.net>
Codecov Report
@@ Coverage Diff @@
## master #15696 +/- ##
==========================================
- Coverage 43.91% 43.89% -0.02%
==========================================
Files 678 678
Lines 81838 81866 +28
==========================================
Hits 35936 35936
- Misses 40052 40083 +31
+ Partials 5850 5847 -3
Continue to review full report at Codecov.
|
|
This also fixes the timeout times reported on the process manager for boost workers and also makes it possible to start all queues with zero workers to allow defaulting to boost when they get some work. |
techknowlogick
approved these changes
May 1, 2021
GiteaBot
added
lgtm/done
zeripath
deleted the
only-use-temporary-workers-for-persistable-level-queues
branch
12 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The leveldb shadow queue of a persistable channel queue should always start with 0
workers and just use boost to add additional workers if necessary.
Fixes #15542
Signed-off-by: Andrew Thornton art27@cantab.net